NULL check environ before dereference
#168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please change the PR to move this check outside the ifdef? Line 122 in d96016b |
|
One more thing, please squash the two commits together, after that lgtm |
dusan-exostellar
force-pushed
the
environ_null_check
branch
from
0acceba to
0ac9bbb
Compare
On UNIX, `clearenv` sets `environ` to NULL. So, NULL is a valid value for `environ`. Signed-off-by: Dušan Veljko <[email protected]>
dusan-exostellar
force-pushed
the
environ_null_check
branch
from
0ac9bbb to
a47e7df
Compare
Done |
rahulc-gh
pushed a commit
that referenced
this pull request
Jun 2, 2025
This was referenced Aug 18, 2025
|
Imported to ROCm/rocm-systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
Closes #164
What type of PR is this? (check all applicable)
What were the changes?
NULL check
environbefore dereference.Why are these changes needed?
To prevent dereferencing NULL pointer.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks